httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: svn commit: r816074 - in /httpd/mod_ftp/trunk/modules/ftp: ftp_commands.c ftp_internal.h ftp_util.c
Date Thu, 17 Sep 2009 13:11:45 GMT

On Sep 17, 2009, at 4:18 AM, William A. Rowe, Jr. wrote:

> rjung@apache.org wrote:
>>
>> Modified: httpd/mod_ftp/trunk/modules/ftp/ftp_internal.h
>> URL: http://svn.apache.org/viewvc/httpd/mod_ftp/trunk/modules/ftp/ftp_internal.h?rev=816074&r1=816073&r2=816074&view=diff
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =====================================================================
>> --- httpd/mod_ftp/trunk/modules/ftp/ftp_internal.h (original)
>> +++ httpd/mod_ftp/trunk/modules/ftp/ftp_internal.h Thu Sep 17  
>> 07:00:24 2009
>> @@ -84,6 +84,8 @@
>>
>> #if APR_HAVE_SYS_STAT_H
>> #include <sys/stat.h>
>> +#elif HAVE_SYS_STAT_H
>> +#include <sys/stat.h>
>> #endif
>
> NAK.  The fragment above makes zero sense, please revert.
>
> #if APR_HAVE_SYS_STAT_H
>
> should be sufficent.  If apr does not provide it consistently, and  
> httpd
> has, then the test becomes
>
> #ifdef HAVE_SYS_STAT_H
>
> which is an altogether different beast.  First clue that the code  
> above was
> wrong is that you included the same code for both cases.  So  
> provided that
> you had no clue if APR consistently provided this and you wanted to  
> rely
> upon config.h, then it becomes
>
> #if (defined(APR_HAVE_SYS_STAT_H) && APR_HAVE_SYS_STAT_H) \
>    || defined(HAVE_SYS_STAT_H)
> #include...
>
> but we know we don't need to go that far.
>

Grok ./modules/generators/mod_cgid.c

   /* ### should be tossed in favor of APR */
   #include <sys/stat.h>

btw :)

I'm sure there's some history there...

Mime
View raw message