httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Fritsch>
Subject Re: Memory usage, core output filter, and apr_brigade_destroy
Date Sun, 13 Sep 2009 17:09:37 GMT
Hi RĂ¼diger,

thanks for the response.

On Sunday 13 September 2009, Ruediger Pluem wrote:
> On 09/13/2009 01:11 PM, Stefan Fritsch wrote:
> >
> > recommends to reuse bucket brigades and to not use
> > apr_brigade_destroy. However, both in 2.2 and in trunk, the core
> > output filter sometimes calls apr_brigade_destroy on brigades
> > that it has received down the chain from earlier output filters.
> > Is this not bound to cause problems since the brigade's pool
> > cleanup is then removed but the brigade is still reused later on?
> It could be. But the questions is if it is really reused later on.

Since this is the recommended design for output filters, I am sure it 
can happen.

> But your patch is causing core dumps during the proxy tests when
> running the test suite :-(.

It seems I should install the test suite, too. I will look at it when 
I have some free cycles again.


View raw message