httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guenter Knauf <fua...@apache.org>
Subject Re: svn commit: r798359 - in /httpd/httpd/branches/2.2.x: modules/ssl/ssl_engine_init.c modules/ssl/ssl_engine_kernel.c modules/ssl/ssl_engine_vars.c modules/ssl/ssl_util_ssl.c support/ab.c
Date Wed, 29 Jul 2009 10:52:53 GMT
Hi Peter,
Peter Sylvester schrieb:
> A little nit in ssl_engine_init.c:
> instead of
> 
> -        SSL_CTX_set_client_CA_list(ctx, (STACK *)ca_list);
> +        SSL_CTX_set_client_CA_list(ctx, (STACK_OF(X509_NAME) *)ca_list);
> 
> I think I'd prefer
> +        SSL_CTX_set_client_CA_list(ctx, ca_list);
but this is not part of the proposed patch?
http://people.apache.org/~fuankg/diffs/openssl-1.x-2.2.x.diff
and its already fixed in HEAD:
http://svn.apache.org/viewvc?view=rev&revision=798274

> and a few lines later instead of
> 
> ca_list = (STACK_OF(X509_NAME) *)SSL_CTX_get_client_CA_list(ctx);
> 
>   it should be
> ca_list = SSL_CTX_get_client_CA_list(ctx);
this is also not part of the patch in question nor is it required.
Instead it is another cleanup which should go the usual way = apply in
HEAD, propose for backport. Please lets separate these things - the
bigger we make the one 2.2.x backport patch the lesser the other
developers are in the mood to review it.

Please lets focus on the proposed 2.2.x patch only at the moment, and
make sure that it compiles warning-free with 0.9.7, 0.9.8 and 1.0.0.

now that the patch was already in 2.2.x trunk it should be very easy to
apply it, just do a:
svn merge -r798358:798359
https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x
and you should get all hunks in ... :)

Gün.




Mime
View raw message