Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 97159 invoked from network); 13 May 2009 20:02:09 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 13 May 2009 20:02:09 -0000 Received: (qmail 30232 invoked by uid 500); 13 May 2009 20:02:08 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 30148 invoked by uid 500); 13 May 2009 20:02:07 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 30139 invoked by uid 99); 13 May 2009 20:02:07 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 May 2009 20:02:07 +0000 X-ASF-Spam-Status: No, hits=1.2 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: 76.96.62.80 is neither permitted nor denied by domain of jim@jagunet.com) Received: from [76.96.62.80] (HELO QMTA08.westchester.pa.mail.comcast.net) (76.96.62.80) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 May 2009 20:01:56 +0000 Received: from OMTA10.westchester.pa.mail.comcast.net ([76.96.62.28]) by QMTA08.westchester.pa.mail.comcast.net with comcast id r0kl1b00n0cZkys5881Kp6; Wed, 13 May 2009 20:01:19 +0000 Received: from [192.168.199.10] ([69.251.84.64]) by OMTA10.westchester.pa.mail.comcast.net with comcast id r81c1b0071PGofZ3W81c5S; Wed, 13 May 2009 20:01:36 +0000 Message-Id: From: Jim Jagielski To: dev@httpd.apache.org In-Reply-To: <2A566FF6-08D3-465C-9466-1E08C14BF16A@jaguNET.com> Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v935.3) Subject: Re: svn commit: r774454 - in /httpd/httpd/trunk: include/ap_slotmem.h modules/mem/mod_plainmem.c modules/mem/mod_sharedmem.c server/slotmem.c Date: Wed, 13 May 2009 16:01:34 -0400 References: <20090513180411.5E5AA2388874@eris.apache.org> <4A0B1DDF.3000500@gmail.com> <2A566FF6-08D3-465C-9466-1E08C14BF16A@jaguNET.com> X-Mailer: Apple Mail (2.935.3) X-Virus-Checked: Checked by ClamAV on apache.org On May 13, 2009, at 3:40 PM, Jim Jagielski wrote: > > On May 13, 2009, at 3:22 PM, jean-frederic clere wrote: > >> jim@apache.org wrote: >>> Author: jim >>> Date: Wed May 13 18:04:05 2009 >>> New Revision: 774454 >>> URL: http://svn.apache.org/viewvc?rev=774454&view=rev >>> Log: >>> ap_slotmem_mem no longer exists. We never provide the ptr to >>> the actual mem. Instead, we rely solely on getter/setter >> >> Why? I am using it :-( >> > > Oops! Sorry. We can add it back in... But what does > ap_slotmem_mem provide that ap_slotmem_get/ap_slotmem_put? > Again, the idea is that we abstract out the memory handling. > So why do you need the memory pointer if you have a getter and > setter which handles accessing... But no prob putting it back. > patch reverted