Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (nike.apache.org: domain of jfclere@gmail.com designates
 74.125.92.147 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:user-agent:mime-version:to:subject:references
         :in-reply-to:content-type:content-transfer-encoding;
        b=GxeUDkj3z/jE/m0C7o3kUHWKlXGuqSO1lNx9f2NPCWfVjW1vno6999hHnvzuJyjwwn
         pM6IDDsnWVBTFzl4bPqU0/XkQdEoTOp073H7Ivt1or6zRq0vTMRKCblPzQXNPVdGG66C
         4diD6C2+itp1jBk5ObQTjaF1jTVTzBP6Ty6i8=
Message-ID: <4A0D1752.30500@gmail.com>
Date: Fri, 15 May 2009 09:18:42 +0200
From: jean-frederic clere <jfclere@gmail.com>
User-Agent: Thunderbird 2.0.0.21 (X11/20090320)
MIME-Version: 1.0
To: dev@httpd.apache.org
Subject: Re: svn commit: r774454 - in /httpd/httpd/trunk: include/ap_slotmem.h
 modules/mem/mod_plainmem.c modules/mem/mod_sharedmem.c server/slotmem.c
References: <20090513180411.5E5AA2388874@eris.apache.org>
 <4A0B1DDF.3000500@gmail.com>
 <2A566FF6-08D3-465C-9466-1E08C14BF16A@jaguNET.com>
 <D2D3CC7F-ACDC-4456-BD53-C79D670FCAE2@jaguNET.com> <4A0BBB26.30005@gmail.com>
 <27E68473-3112-4AE3-832B-5736A6A18544@jaguNET.com>
 <B032FAE0-4B23-44A2-8625-698B48AC4A15@jaguNET.com>
In-Reply-To: <B032FAE0-4B23-44A2-8625-698B48AC4A15@jaguNET.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Jim Jagielski wrote:
> 
> On May 14, 2009, at 10:16 AM, Jim Jagielski wrote:
> 
>>
>> On May 14, 2009, at 2:33 AM, jean-frederic clere wrote:
>>> Thanks.
>>> The idea of ap_slotmem_mem is to provide an address in the shared 
>>> area that can be used for example like the proxy_worker_stat. Using 
>>> get/put would require 2 memcpy.... I hate memcpy :)
>>>
>>
>> This is true... Updating would require a memcpy to read in and a memcpy
>> to update, whereas having a pointer means we can adjust the slot
>> as is (at most, one memcpy). Most slots would need to return APR_ENOTIMPL
>> because a concept of a "pointer to a slot" doesn't make sense.
>>
> 
> Hmmmm maybe instead of slotmem_mem we call it slotmem_dptr (for 
> direct-pointer),
> to make it clearer?? SQL-based slots, for example, would not have a
> dptr and would return APR_ENOTIMPL.
> 

+1. Good names help :-)

Cheers

Jean-Frederic