Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (athena.apache.org: domain of jfclere@gmail.com designates
 209.85.221.130 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:user-agent:mime-version:to:subject:references
         :in-reply-to:content-type:content-transfer-encoding;
        b=rkOCEYmxd+qHiJZcpGaMax1YZRemApBc0IKK9mEpfgdgEaRk7HGeLYrx2+7x6YLgbg
         S46AXodb0n9VZPp/c8p8qrcNy6kiiUTly97Z+ttkMv++OxlqPnBEid5A4L5DMRPsGPKH
         eLZ4pFW2SF/8MpIqdaRLs14bvvg3OHsGc346I=
Message-ID: <4A0BBB26.30005@gmail.com>
Date: Thu, 14 May 2009 08:33:10 +0200
From: jean-frederic clere <jfclere@gmail.com>
User-Agent: Thunderbird 2.0.0.21 (X11/20090320)
MIME-Version: 1.0
To: dev@httpd.apache.org
Subject: Re: svn commit: r774454 - in /httpd/httpd/trunk: include/ap_slotmem.h
 modules/mem/mod_plainmem.c modules/mem/mod_sharedmem.c server/slotmem.c
References: <20090513180411.5E5AA2388874@eris.apache.org>
 <4A0B1DDF.3000500@gmail.com>
 <2A566FF6-08D3-465C-9466-1E08C14BF16A@jaguNET.com>
 <D2D3CC7F-ACDC-4456-BD53-C79D670FCAE2@jaguNET.com>
In-Reply-To: <D2D3CC7F-ACDC-4456-BD53-C79D670FCAE2@jaguNET.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Jim Jagielski wrote:
> 
> On May 13, 2009, at 3:40 PM, Jim Jagielski wrote:
> 
>>
>> On May 13, 2009, at 3:22 PM, jean-frederic clere wrote:
>>
>>> jim@apache.org wrote:
>>>> Author: jim
>>>> Date: Wed May 13 18:04:05 2009
>>>> New Revision: 774454
>>>> URL: http://svn.apache.org/viewvc?rev=774454&view=rev
>>>> Log:
>>>> ap_slotmem_mem no longer exists. We never provide the ptr to
>>>> the actual mem. Instead, we rely solely on getter/setter
>>>
>>> Why? I am using it :-(
>>>
>>
>> Oops! Sorry. We can add it back in... But what does
>> ap_slotmem_mem provide that ap_slotmem_get/ap_slotmem_put?
>> Again, the idea is that we abstract out the memory handling.
>> So why do you need the memory pointer if you have a getter and
>> setter which handles accessing... But no prob putting it back.
>>
> 
> patch reverted

Thanks.
The idea of ap_slotmem_mem is to provide an address in the shared area 
that can be used for example like the proxy_worker_stat. Using get/put 
would require 2 memcpy.... I hate memcpy :)

Cheers

Jean-Frederic

>