Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (nike.apache.org: domain of covener@gmail.com designates
 209.85.220.162 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=m646GyoJZ7gLFoNE3iaOUbyfC4zdGxOiZZDLSL3/v0ywkEM3xktgWdSM8NskDwLp1M
         OuAyKy+mCgtF7cuzt0KJ2MqWXv9qtgNx0X/TXOjQDBxqkJzTwcLv3YVwXUL4EdigyFeF
         qtjmPIQquoQVbjD7QGhqAnooVrWKgTqDW0gdA=
MIME-Version: 1.0
In-Reply-To: <1404e5910905091116l427847cch215a76209fac110a@mail.gmail.com>
References: <20090508141316.4EC0223888A2@eris.apache.org>
	 <1404e5910905091116l427847cch215a76209fac110a@mail.gmail.com>
Date: Sat, 9 May 2009 17:24:46 -0400
Message-ID: <1404e5910905091424t18ac2326j228fb441ff7ff717@mail.gmail.com>
Subject: Re: svn commit: r772997 - in /httpd/httpd/trunk: include/http_core.h
	modules/filters/mod_include.c server/config.c server/core.c
From: Eric Covener <covener@gmail.com>
To: dev@httpd.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Sat, May 9, 2009 at 2:16 PM, Eric Covener <covener@gmail.com> wrote:
> On Fri, May 8, 2009 at 10:13 AM, =A0<jorton@apache.org> wrote:
>
>> +
>> + =A0 =A0 =A0 =A0/* if Includes was enabled without exec in the new conf=
ig, but
>> + =A0 =A0 =A0 =A0 * was enabled with exec in the base, then disable exec=
 in the
>> + =A0 =A0 =A0 =A0 * resulting options. */
>> + =A0 =A0 =A0 =A0if ((base->opts & OPT_INC_WITH_EXEC)
>> + =A0 =A0 =A0 =A0 =A0 =A0&& (new->opts & OPT_INC_WITH_EXEC) =3D=3D 0) {
>> + =A0 =A0 =A0 =A0 =A0 =A0conf->opts &=3D ~OPT_INC_WITH_EXEC;
>
>
> The above is wrapped in
> =A0 =A0if (new->opts & OPT_UNSET) {
>
> Which means checking new->opts against anything is probably not needed

Not likely the case due to test failures removing this block.

--=20
Eric Covener
covener@gmail.com