httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philip M. Gollucci" <pgollu...@p6m7g8.com>
Subject Re: support/apxs.in has been broken for over a decade ?
Date Tue, 19 May 2009 19:49:18 GMT
William A. Rowe, Jr. wrote:
> Philip M. Gollucci wrote:
>> The following freebsd bug was filed recently:
>>
>>   http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/133704
>>
>> Though we've seen hints of this other places with httpd.conf not getting
>> removed on deinstall b/c it differs from the original httpd.conf.
>>
>> So, as the bug states, I've verified this issue exists in SVN
>> {trunk, branches/2.2.x, branches/2.0.x}; eidontcare 1.3.x
>>
>> The following patch fixes it:
>>
>>   http://people.apache.org/~pgollucci/support_apxs.in.diff
> 
> Huh?  How does right justifying the module names by dropping the '-'
> (what a weird looking module list) solve anything?
So by default httpd.conf is populated by Makefile.in via sed.
The method it uses DOES NOT MATCH the one support/apxs uses.

apxs forces the modulename +spaces to be exactly 18 characters.
Sometimes that means there are MORE then 1 space after the modulename.
In most cases actually since most are shorter.

The regexes in support/apxs in @lmd contain the fulls spaces and thus fail to 
match the default ones generated which have exactly 1 space regardless of length.

The other fix is to change support/apxs to replace ' ' with \s+ in @lmd ($lmd)

To answer your immediate question I didn't right, center, or left justify 
anything in the patch. I'm actualy making the columns line up less by dropping 
the %-18.

Currently apxs expects this which will never match the below unless you take 
into account WHITESPACE:

            012345678901234567
LoadModule foobar             path/foobar.so

Makefile.in via sed generates

LoadModule foobar path/foobar.so



------------------------------------------------------------------------
1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70  3F8C 75B8 8FFB DB9B 8C1C
Philip M. Gollucci (pgollucci@p6m7g8.com) c: 703.336.9354
Consultant          - P6M7G8 Inc.                http://p6m7g8.net
Senior Sys Admin    - RideCharge, Inc.           http://ridecharge.com
Contractor          - PositiveEnergyUSA          http://positiveenergyusa.com
ASF Member          - Apache Software Foundation http://apache.org
FreeBSD Committer   - FreeBSD Foundation         http://freebsd.org

Work like you don't need the money,
love like you'll never get hurt,
and dance like nobody's watching.

Mime
View raw message