httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rainer Jung <>
Subject Re: svn commit: r735516 - /httpd/httpd/trunk/server/log.c
Date Fri, 15 May 2009 07:41:13 GMT
On 14.05.2009 15:49, Joe Orton wrote:
> On Thu, May 14, 2009 at 12:51:18PM +0200, Rainer Jung wrote:
>> On 13.05.2009 22:38, William A. Rowe, Jr. wrote:
>>> Please revert the introduction of a _wrapper struct and let's simply
>>> fix the piped_log structure?
>> Do we really want to add it to the public API?
> There's no need for that structure to be exposed at all.  I had a patch 
> to fix that lying around - updated for trunk below and can commit later 
> when I've had time to test.

I did some testing, looks good (only needed to add AP_DECLARE to the two
functions moved into log.c to silence MSVC). Should I wait for your
tests, or should I apply?



View raw message