httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jean-frederic clere <jfcl...@gmail.com>
Subject Re: svn commit: r774454 - in /httpd/httpd/trunk: include/ap_slotmem.h modules/mem/mod_plainmem.c modules/mem/mod_sharedmem.c server/slotmem.c
Date Fri, 15 May 2009 07:18:42 GMT
Jim Jagielski wrote:
> 
> On May 14, 2009, at 10:16 AM, Jim Jagielski wrote:
> 
>>
>> On May 14, 2009, at 2:33 AM, jean-frederic clere wrote:
>>> Thanks.
>>> The idea of ap_slotmem_mem is to provide an address in the shared 
>>> area that can be used for example like the proxy_worker_stat. Using 
>>> get/put would require 2 memcpy.... I hate memcpy :)
>>>
>>
>> This is true... Updating would require a memcpy to read in and a memcpy
>> to update, whereas having a pointer means we can adjust the slot
>> as is (at most, one memcpy). Most slots would need to return APR_ENOTIMPL
>> because a concept of a "pointer to a slot" doesn't make sense.
>>
> 
> Hmmmm maybe instead of slotmem_mem we call it slotmem_dptr (for 
> direct-pointer),
> to make it clearer?? SQL-based slots, for example, would not have a
> dptr and would return APR_ENOTIMPL.
> 

+1. Good names help :-)

Cheers

Jean-Frederic

Mime
View raw message