httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: svn commit: r774884 - /httpd/httpd/trunk/server/log.c
Date Thu, 14 May 2009 21:32:21 GMT
William A. Rowe, Jr. wrote:
> rjung@apache.org wrote:
>> Author: rjung
>> Date: Thu May 14 19:13:17 2009
>> New Revision: 774884
>>
>> URL: http://svn.apache.org/viewvc?rev=774884&view=rev
>> Log:
>> Revert r774755: ap_server_root_relative() for
>>
>> piped loggers is nonsense. It doesn't work when
>> the logger path contains whitespace.
> 
> Ok; not sure what you mean here.  All of the following work today
> provided the cwd is the path of httpd root;
> 
> ErrorLog "|/opt/apache\ server/bin/rotatelogs logs/foo.log 1M"
> ErrorLog "|"c:\program files\apache\bin\rotatelogs" logs/foo.log 1M"
> ErrorLog "|bin/rotatelogs logs/foo.log 1M"
> 
> Now even if the good intentions of the patch helped to resolve the
> program-path, it doesn't help to solve the other argv elts which
> represent paths.  The solution is for the cwd to be the server root.
> 
>> We already allow relative paths because we open
>> the log program via the shell.
> 
> :)

Caviat; you might be looking for this API to ensure correct behavior;

http://apr.apache.org/docs/apr/1.3/group__apr__thread__proc.html#g97766f50b0ae083a2f8a28e698a59baa

Mime
View raw message