httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rainer Jung <rainer.j...@kippdata.de>
Subject Re: svn commit: r774755 - in /httpd/httpd/trunk: CHANGES server/log.c
Date Thu, 14 May 2009 20:08:35 GMT
On 14.05.2009 18:50, William A. Rowe, Jr. wrote:
> Rainer Jung wrote:
>> The code is identical to what we do in mod_rewrite and mod_log_forensic.
>> I'll check the details, but I didn't commit this in January without
>> testing especially with rotatelogs and params.
> 
> Thanks for pointing me at those other bugs!  There's little need to dwell
> on the fact that mod_rewrite was entirely unix-centric, and that the
> mod_log_forensic was probably a cut-n-paste from the same.  I'll review
> and fix.

I checked it and you are totally right. Using ap_server_root_relative()
breaks whitespace handling. I'll do a separate post about some
inconsistencies in the path handling between Windows and Unix.

Thanks for the heads up!

Mime
View raw message