httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rainer Jung <rainer.j...@kippdata.de>
Subject Re: svn commit: r735516 - /httpd/httpd/trunk/server/log.c
Date Thu, 14 May 2009 14:24:01 GMT
On 14.05.2009 15:49, Joe Orton wrote:
> On Thu, May 14, 2009 at 12:51:18PM +0200, Rainer Jung wrote:
>> On 13.05.2009 22:38, William A. Rowe, Jr. wrote:
>>> Please revert the introduction of a _wrapper struct and let's simply
>>> fix the piped_log structure?
>> Do we really want to add it to the public API?
> 
> There's no need for that structure to be exposed at all.  I had a patch 
> to fix that lying around - updated for trunk below and can commit later 
> when I've had time to test.

Right, we only actually use ap_piped_log_write_fd() directly after
ap_close_piped_log() (apart from the things in log.c themselves) and
none of the functions in the public log API need to expose the
definition of the struct. Good catch!

Is removing a structure definition from a public header file allowed
between 2.2 and 2.4? Phrased differently: would it allowed for a module
author to use the structure details available in the installed 2.2
header file and can he expect to be able to simply recompile his module
for 2.4?

Rainer

Mime
View raw message