httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Eric Covener <cove...@gmail.com>
Subject Re: svn commit: r772997 - in /httpd/httpd/trunk: include/http_core.h modules/filters/mod_include.c server/config.c server/core.c
Date Sat, 09 May 2009 21:24:46 GMT
On Sat, May 9, 2009 at 2:16 PM, Eric Covener <covener@gmail.com> wrote:
> On Fri, May 8, 2009 at 10:13 AM,  <jorton@apache.org> wrote:
>
>> +
>> +        /* if Includes was enabled without exec in the new config, but
>> +         * was enabled with exec in the base, then disable exec in the
>> +         * resulting options. */
>> +        if ((base->opts & OPT_INC_WITH_EXEC)
>> +            && (new->opts & OPT_INC_WITH_EXEC) == 0) {
>> +            conf->opts &= ~OPT_INC_WITH_EXEC;
>
>
> The above is wrapped in
>    if (new->opts & OPT_UNSET) {
>
> Which means checking new->opts against anything is probably not needed

Not likely the case due to test failures removing this block.

-- 
Eric Covener
covener@gmail.com

Mime
View raw message