httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: segfaults / core dumps caused by ap_internal_fast_redirect
Date Mon, 20 Apr 2009 13:58:12 GMT

On Apr 19, 2009, at 7:58 AM, Ruediger Pluem wrote:
> As I have seen no further proposals in the last 14 days for a  
> replacement
> of ap_internal_fast_redirect (as said I have no idea either) I would  
> like
> to fix the current code to avoid the segfaults that are currently  
> occurring.
> My outlined approach is the following:
>
> 1. Create _ex versions of ap_sub_req_lookup_uri /  
> ap_sub_req_lookup_dirent
>   and ap_sub_req_lookup_file that allow to supply a pool from which  
> the
>   subrequest allocates memory.
>
> 2. Let ap_internal_fast_redirect spit out a warning to the error log  
> if
>   the subrequest pool is different from the request pool.
>
> 3. Fix the current internal consumers of ap_internal_fast_redirect  
> (mod_dir /
>   mod_negotiation to use the _ex versions and feed them with the  
> request pool.
>

I can't think of anything better without some pretty significant
refactoring of a LOT of code... So +1


Mime
View raw message