Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 94953 invoked from network); 2 Mar 2009 13:34:39 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 2 Mar 2009 13:34:39 -0000 Received: (qmail 65625 invoked by uid 500); 2 Mar 2009 13:34:36 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 65571 invoked by uid 500); 2 Mar 2009 13:34:36 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 65562 invoked by uid 99); 2 Mar 2009 13:34:36 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Mar 2009 05:34:36 -0800 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=MIME_QP_LONG_LINE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [75.127.97.246] (HELO thumper.thorarinson.com) (75.127.97.246) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Mar 2009 13:34:29 +0000 Received: from thumper.thorarinson.com (localhost [127.0.0.1]) by thumper.thorarinson.com (Postfix) with ESMTP id 6C0F4B781B0; Mon, 2 Mar 2009 08:34:08 -0500 (EST) Received: from [10.8.2.4] (unknown [10.8.2.4]) by thumper.thorarinson.com (Postfix) with ESMTPA id D6D72B781A1; Mon, 2 Mar 2009 08:34:05 -0500 (EST) User-Agent: Microsoft-Entourage/12.13.0.080930 Date: Mon, 02 Mar 2009 08:34:05 -0500 Subject: Re: patch for handling headers_in and headers_out as tables in mod_lua From: Brian Akins To: "dev@httpd.apache.org" , Message-ID: Thread-Topic: patch for handling headers_in and headers_out as tables in mod_lua Thread-Index: AcmbO45TU4qPeBfwNk6g2vide18NeQ== In-Reply-To: <9338f5ad0902281737l24b9440cv7859220e4510ca39@mail.gmail.com> Mime-version: 1.0 Content-type: text/plain; charset="ISO-8859-1" Content-transfer-encoding: quoted-printable X-Virus-Scanned: ClamAV using ClamSMTP X-Virus-Checked: Checked by ClamAV on apache.org On 2/28/09 8:37 PM, "Brian McCallister" wrote: >> It could be just: >> =A0 =A0apr_hash_set(dispatch, "document_root", APR_HASH_KEY_STRING, >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 makefun(&req_content_encoding_field, APL_REQ_FUNTYPE_STR= ING, >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 p)); >=20 Also, couldn't we build the dispatch has once, and only once, and then just associated it with each apache2.request? This seems more efficient than building this array every time. It would also be nice to use a dispatch hash for "setters" as well. --Brian