Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (athena.apache.org: domain of nickgearls@gmail.com
 designates 64.233.182.188 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:user-agent:mime-version:to:subject:references
         :in-reply-to:content-type:content-transfer-encoding;
        b=SMM7nY41a2BAgA8yIAbLeaOe6T/IiiqyUAHenKwRFIbtPpHF5COz3A6N+trs3+vF+g
         WagMbKu7W9F6mfqbaOsNnT+Sipf+9nrjHO97806581eIremxcomstIGV4YcsUzedZpJ6
         P5mko/kO+NWXXvJZ8co/6hCospg5+MBLOaAyM=
Message-ID: <49BE159A.2050601@gmail.com>
Date: Mon, 16 Mar 2009 10:02:18 +0100
From: Nick Gearls <nickgearls@gmail.com>
User-Agent: Thunderbird 2.0.0.19 (Windows/20081209)
MIME-Version: 1.0
To: dev@httpd.apache.org
Subject: Re: mod_substitute & back-references
References: <49B51AFF.3010004@gmail.com>
	 <99EA83DCDE961346AFA9B5EC33FEC08B01DEEFD8@VF-MBX11.internal.vodafone.com>
	 <49B65698.1040102@gmail.com>
 <1404e5910903100522v2d322f38td5f9b0b932eca56f@mail.gmail.com>
 <49B77E6B.20505@gmail.com> <4D28ADC3-74E2-4CCB-BB32-EC21C10FDAA1@jaguNET.com>
 <49B9429D.9010907@gmail.com> <49B96AB4.7090501@apache.org>
 <49BA5609.3070808@gmail.com>
 <99EA83DCDE961346AFA9B5EC33FEC08B01E8C3DC@VF-MBX11.internal.vodafone.com>
 <49BA6D0F.8010101@gmail.com>
 <99EA83DCDE961346AFA9B5EC33FEC08B01E8C423@VF-MBX11.internal.vodafone.com>
In-Reply-To: 
 <99EA83DCDE961346AFA9B5EC33FEC08B01E8C423@VF-MBX11.internal.vodafone.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit

Different result, but still incorrect:
   Substitute s|abc|---abc+++|n
changes "abc" to "---------abc+++++++++"

Regards,

Nick


Pl�m, R�diger, VF-Group wrote:
> Ok. Now I could reproduce it. Could you please check if the following patch
> fixes it for you?
> 
> Index: modules/filters/mod_substitute.c
> ===================================================================
> --- modules/filters/mod_substitute.c    (revision 753197)
> +++ modules/filters/mod_substitute.c    (working copy)
> @@ -199,7 +199,6 @@
>                          tmp_b = apr_bucket_transient_create(s1, strlen(s1),
>                                              f->r->connection->bucket_alloc);
>                          APR_BUCKET_INSERT_BEFORE(b, tmp_b);
> -                        tmp_b = APR_BUCKET_NEXT(b);
>                          apr_bucket_delete(b);
>                          b = tmp_b;
>                      }
> @@ -249,7 +248,6 @@
>                          tmp_b = apr_bucket_transient_create(s1, strlen(s1),
>                                              f->r->connection->bucket_alloc);
>                          APR_BUCKET_INSERT_BEFORE(b, tmp_b);
> -                        tmp_b = APR_BUCKET_NEXT(b);
>                          apr_bucket_delete(b);
>                          b = tmp_b;
>                      }
> 
> Regards
> 
> R�diger
> 
>> -----Urspr�ngliche Nachricht-----
>> Von: Nick Gearls 
>> Gesendet: Freitag, 13. M�rz 2009 15:26
>> An: dev@httpd.apache.org
>> Betreff: Re: mod_substitute & back-references
>>
>> No, only once at a time.
>> It's just to give several examples
>>
>> Regards,
>>
>> Nick
>>
>>
>> Pl�m, R�diger, VF-Group wrote:
>>>  
>>>
>>>> -----Urspr�ngliche Nachricht-----
>>>> Von: Nick Gearls 
>>>> Gesendet: Freitag, 13. M�rz 2009 13:48
>>>> An: dev@httpd.apache.org
>>>> Betreff: Re: mod_substitute & back-references
>>>>
>>>> You can reproduce the problems on this file:
>>>> 	<html><body>
>>>> 	abc
>>>> 	</body></html>
>>>>
>>>> 1. Substitute s|abc|abc|n     ->  OK: "abc"
>>>> 2. Substitute s|abc|+abc|     -> NOK: "+++abc"
>>>> 3. Substitute s|abc|++abc|nq  -> NOK: "++++++abc"
>>>> 4. Substitute s|abc|+++abc|q  -> NOK: "+++++++++abc"
>>> Are you using all these above at the same time?
>>>
>>> Regards
>>>
>>> R�diger
>>>
>>>
>