httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Plüm, Rüdiger, VF-Group" <ruediger.pl...@vodafone.com>
Subject Re: mod_substitute & back-references
Date Fri, 13 Mar 2009 14:59:51 GMT
Ok. Now I could reproduce it. Could you please check if the following patch
fixes it for you?

Index: modules/filters/mod_substitute.c
===================================================================
--- modules/filters/mod_substitute.c    (revision 753197)
+++ modules/filters/mod_substitute.c    (working copy)
@@ -199,7 +199,6 @@
                         tmp_b = apr_bucket_transient_create(s1, strlen(s1),
                                             f->r->connection->bucket_alloc);
                         APR_BUCKET_INSERT_BEFORE(b, tmp_b);
-                        tmp_b = APR_BUCKET_NEXT(b);
                         apr_bucket_delete(b);
                         b = tmp_b;
                     }
@@ -249,7 +248,6 @@
                         tmp_b = apr_bucket_transient_create(s1, strlen(s1),
                                             f->r->connection->bucket_alloc);
                         APR_BUCKET_INSERT_BEFORE(b, tmp_b);
-                        tmp_b = APR_BUCKET_NEXT(b);
                         apr_bucket_delete(b);
                         b = tmp_b;
                     }

Regards

Rüdiger

> -----Ursprüngliche Nachricht-----
> Von: Nick Gearls 
> Gesendet: Freitag, 13. März 2009 15:26
> An: dev@httpd.apache.org
> Betreff: Re: mod_substitute & back-references
> 
> No, only once at a time.
> It's just to give several examples
> 
> Regards,
> 
> Nick
> 
> 
> Plüm, Rüdiger, VF-Group wrote:
> >  
> > 
> >> -----Ursprüngliche Nachricht-----
> >> Von: Nick Gearls 
> >> Gesendet: Freitag, 13. März 2009 13:48
> >> An: dev@httpd.apache.org
> >> Betreff: Re: mod_substitute & back-references
> >>
> >> You can reproduce the problems on this file:
> >> 	<html><body>
> >> 	abc
> >> 	</body></html>
> >>
> >> 1. Substitute s|abc|abc|n     ->  OK: "abc"
> >> 2. Substitute s|abc|+abc|     -> NOK: "+++abc"
> >> 3. Substitute s|abc|++abc|nq  -> NOK: "++++++abc"
> >> 4. Substitute s|abc|+++abc|q  -> NOK: "+++++++++abc"
> > 
> > Are you using all these above at the same time?
> > 
> > Regards
> > 
> > Rüdiger
> > 
> > 
> 

Mime
View raw message