httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sander Temme <scte...@apache.org>
Subject Re: svn commit: r748396 - in /httpd/httpd/trunk: modules/ssl/ssl_engine_init.c modules/ssl/ssl_engine_kernel.c modules/ssl/ssl_engine_vars.c modules/ssl/ssl_util_ssl.c support/ab.c
Date Wed, 04 Mar 2009 00:19:08 GMT

On Mar 3, 2009, at 11:55 AM, Ruediger Pluem wrote:

>> Modified: httpd/httpd/trunk/modules/ssl/ssl_engine_vars.c
>> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/ssl/ssl_engine_vars.c?rev=748396&r1=748395&r2=748396&view=diff
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =====================================================================
>> --- httpd/httpd/trunk/modules/ssl/ssl_engine_vars.c (original)
>> +++ httpd/httpd/trunk/modules/ssl/ssl_engine_vars.c Fri Feb 27  
>> 05:16:18 2009
>
>> @@ -653,7 +653,7 @@
>>
>> static void ssl_var_lookup_ssl_cipher_bits(SSL *ssl, int  
>> *usekeysize, int *algkeysize)
>> {
>> -    SSL_CIPHER *cipher;
>> +    const SSL_CIPHER *cipher;
>>
>>     *usekeysize = 0;
>>     *algkeysize = 0;
>>
>
> This causes
>
> ssl_engine_vars.c: In function `ssl_var_lookup_ssl_cipher_bits':
> ssl_engine_vars.c:662: warning: passing arg 1 of  
> `SSL_CIPHER_get_bits' discards qualifiers from pointer target type

Huh.  Didn't see that one.  I tested with system OpenSSL on my Mac  
(which professes to be 0.9.7l of 28 Sep 2006), 0.9.8j and a HEAD  
snapshot from a couple of weeks ago.

> on RedHat AS 4 with RedHat provided OpenSSL 0.9.7a. No issue with  
> SuSE distro provided OpenSSL 0.9.8d.


Yes.  Similar to the ab.c case, this was constified in the function  
definition.  However, this time it happened somewhere between 0.9.7a  
(+ RH patches) and 0.9.7l (as supplied by Apple), and has always been  
the case in 0.9.8 and HEAD.

Annoying.

S.

-- 
Sander Temme
sctemme@apache.org
PGP FP: 51B4 8727 466A 0BC3 69F4  B7B8 B2BE BC40 1529 24AF




Mime
View raw message