Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 11360 invoked from network); 8 Feb 2009 20:36:30 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 8 Feb 2009 20:36:30 -0000 Received: (qmail 58967 invoked by uid 500); 8 Feb 2009 20:36:28 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 58920 invoked by uid 500); 8 Feb 2009 20:36:28 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 58910 invoked by uid 99); 8 Feb 2009 20:36:28 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 08 Feb 2009 12:36:28 -0800 X-ASF-Spam-Status: No, hits=-1.0 required=10.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy) Received: from [209.237.226.90] (HELO hyperreal.org) (209.237.226.90) by apache.org (qpsmtpd/0.29) with SMTP; Sun, 08 Feb 2009 20:36:20 +0000 Received: (qmail 52003 invoked from network); 8 Feb 2009 20:35:40 -0000 Received: from localhost.hyperreal.org (HELO doubleshadow.eilebrecht.net) (127.0.0.1) by localhost.hyperreal.org with SMTP; 8 Feb 2009 20:35:40 -0000 Received: from localhost ([127.0.0.1] helo=shadow) by doubleshadow.eilebrecht.net with esmtp (Exim 4.67) (envelope-from ) id 1LWGNh-0004SM-HO for dev@httpd.apache.org; Sun, 08 Feb 2009 21:35:57 +0100 Date: Sun, 8 Feb 2009 20:35:55 +0000 From: "Lars Eilebrecht" To: dev@httpd.apache.org Subject: Re: use of APR_SENDFILE_ENABLED in mod_disk_cache In-Reply-To: <498DF72A.6030807@apache.org> References: <20090207200257.GA32519@eilebrecht.net> <498DF72A.6030807@apache.org> X-Mailer: Claws Mail 3.5.0 (GTK+ 2.14.4; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Message-Id: X-Spam-Rating: localhost.hyperreal.org 1.6.2 0/1000/N X-Virus-Checked: Checked by ClamAV on apache.org Ruediger Pluem wrote on 2009-02-07 22:03:38: > IMHO this is correct. The problem is that we do not know at this > point of time how EnableSendFile is set. We are in the quick handler > and have not done any directory walks (and in fact if the cached > entry is good we never will). > So the only option I see here is to add another directive for > mod_disk_cache to determine what should be done. Well, but if EnableSendfile is configured in the main config or vhost we get the setting by looking at the core_module config. Of course you are right that this doesn't work when it is defined inside a Location or Directory section. We could just add a note to the mod_disk_cache configuration that EnableSendfile will only be taken into account when configured globally for the server or vhost. IMHO that's good enough for such a special case. I would like to avoid a dedicated sendfile directive just for mod_disk_cache. ciao... -- Lars Eilebrecht lars@eilebrecht.net