Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 2947 invoked from network); 6 Feb 2009 05:22:15 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 6 Feb 2009 05:22:15 -0000 Received: (qmail 50001 invoked by uid 500); 6 Feb 2009 05:22:12 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 49946 invoked by uid 500); 6 Feb 2009 05:22:12 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 49937 invoked by uid 99); 6 Feb 2009 05:22:12 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Feb 2009 21:22:12 -0800 X-ASF-Spam-Status: No, hits=1.2 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [209.85.221.21] (HELO mail-qy0-f21.google.com) (209.85.221.21) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Feb 2009 05:22:04 +0000 Received: by qyk14 with SMTP id 14so1052678qyk.0 for ; Thu, 05 Feb 2009 21:21:42 -0800 (PST) MIME-Version: 1.0 Received: by 10.214.215.10 with SMTP id n10mr2067019qag.74.1233897702589; Thu, 05 Feb 2009 21:21:42 -0800 (PST) Date: Thu, 5 Feb 2009 21:21:42 -0800 Message-ID: <9338f5ad0902052121y4ef5487l4ca27d62f3b61a40@mail.gmail.com> Subject: [mod_lua] bytecode caching From: Brian McCallister To: dev@httpd.apache.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org It looks like fields were added to apl_vm_spec to allow for bytecode caching on the actual spec. I think this is a bad idea. Specs are short-lived, typically stack-allocated, structs which exist to group a bunch of arguments together. If we choose to re-enable bytecode caching in mod_lua, it should be done as a hook on source code loading where the cache is managed by the bytecode caching module (which may be mod_lua, or may not be) and if the cache hook doesn't fill in the sources, the fallback one loads the file an compiles them. -Brian