Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (athena.apache.org: domain of nickgearls@gmail.com
 designates 66.249.92.173 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:user-agent:mime-version:to:subject:references
         :in-reply-to:content-type:content-transfer-encoding;
        b=qpo7zF3kEsinNyJAnx9V5Ewvyn7OHDnsJKo0cufQ8FIE7SOSFGdpzXLItFrvy8tghP
         H+n61PEVDcM92JULdGmhHT9FOZ2h1q7P6PHEOEAq9Hb8pHEvZPYJ9Ue/zKZP5C3Xremd
         yyyn00CUY1KU0Mog12E+73DXUjeHEZVli4yKk=
Message-ID: <498AADAD.7020002@gmail.com>
Date: Thu, 05 Feb 2009 10:13:17 +0100
From: Nick Gearls <nickgearls@gmail.com>
User-Agent: Thunderbird 2.0.0.19 (Windows/20081209)
MIME-Version: 1.0
To: Development Apache <dev@httpd.apache.org>
Subject: Re: ProxyErrorOverride inside location
References: <49881ECE.8070802@gmail.com>
In-Reply-To: <49881ECE.8070802@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

It seems there is a little problem in my code.
When defining "ProxyErrorOverride On" at the vhost level, then 
"ProxyErrorOverride Off" at a directory level, the directive does not 
seem to work at the directory level.

The merge works correctly, I traced it, and "error_override" is set to 1 
at global level, then to 0 at the dir level.
But in "ap_proxy_http_process_response()", dconf->error_override" is 
always set to 1. dconf is built as usual:
proxy_dir_conf *dconf = ap_get_module_config(r->per_dir_config, 
&proxy_module);

Any idea ?

Thanks,

Nick


Nick Gearls wrote:
> A patch is submitted: 
> https://issues.apache.org/bugzilla/show_bug.cgi?id=46656
> 
> Here are the modifs:
> - added |ACCESS_CONF to AP_INIT_FLAG
> - error_override & error_override_set are moved to proxy_dir_conf
> - set_proxy_error_override() is modified to use provided dconf*
> 
> As I explained, this is very useful when using Web Services, as SOAP 
> errors are reported inside status 500 pages.
> 
> Will this be added ?
> 
>