httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Niklas Edmundsson <ni...@acc.umu.se>
Subject Re: use of APR_SENDFILE_ENABLED in mod_disk_cache
Date Mon, 16 Feb 2009 10:06:33 GMT
On Sun, 8 Feb 2009, Ruediger Pluem wrote:

>> Yes, it is. The following seems to work fine:
>>
>> Index: mod_disk_cache.c
>> ===================================================================
>> --- mod_disk_cache.c	(revision 742187)
>> +++ mod_disk_cache.c	(working copy)
>> @@ -471,7 +471,10 @@
>>      /* Open the data file */
>>      flags = APR_READ|APR_BINARY;
>>  #ifdef APR_SENDFILE_ENABLED
>> -    flags |= APR_SENDFILE_ENABLED;
>> +    core_dir_config *coreconf = ap_get_module_config(r->per_dir_config,
>> +                                                     &core_module);
>

> This is not ANSI C compatible. Please declare coreconf at the 
> beginning of the block. Otherwise no objections.

+1 when ansified.


/Nikke
-- 
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
  Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se      |     nikke@acc.umu.se
---------------------------------------------------------------------------
  To err is human, to forgive is unusual.
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Mime
View raw message