httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: mod_proxy_balancer lbset functionality
Date Sun, 01 Feb 2009 21:51:51 GMT

On Feb 1, 2009, at 3:08 AM, Mladen Turk wrote:

> Hi,
>
> Think Jim introduced the lbset balancer property, so he would probably
> know best how this is supposed to work.
>
> IIUC lbset should allow to create the group of balancer members,
> and that's great. However IMO the logic inside balancer providers
> in not valid. The balancing should be done for a particular
> set, however IMO it's done always from 0...current set
>
> Here is the code
> if (worker->s->lbset > cur_lbset)
>  continue;
> ...
> cur_lbset++
>
> IMO it should be
> if (worker->s->lbset != cur_lbset)
>  continue;
> ...
> cur_lbset++
>

Yes... the current logic assumes that the ordering of the
configed lbsets is sequential, which is not a valid assumption.

fixed. Thanks!


Mime
View raw message