httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ruediger Pluem <rpl...@apache.org>
Subject Re: CacheIgnoreHeaders not working correctly
Date Wed, 11 Feb 2009 19:55:06 GMT


On 02/11/2009 02:10 PM, Lars Eilebrecht wrote:
> Ruediger Pluem wrote:
> 
>> http://svn.apache.org/viewvc?view=rev&revision=649162
>> http://svn.apache.org/viewvc?view=rev&revision=649791
> 
> Hmm ... I'm not sure I understand the logic in this one:
> 
> CACHE_DECLARE(apr_table_t *)ap_cache_cacheable_headers_out(request_rec * r)
> {
>     apr_table_t *headers_out;
> 
>     headers_out = apr_table_overlay(r->pool, r->headers_out,
>                                         r->err_headers_out);
> 
>     apr_table_clear(r->err_headers_out);
> 
>     headers_out = ap_cache_cacheable_headers(r->pool, r->headers_out,
>                                                   r->server);
> 
>     if (!apr_table_get(headers_out, "Content-Type")
>         && r->content_type) {
>         apr_table_setn(headers_out, "Content-Type",
>                        ap_make_content_type(r, r->content_type));
>     }
> 
>     return headers_out;
> }
>  
> 
> It merges r->headers_out and r->err_headers_out into headers_out,
> then clears r->err_headers_out (?), and then ap_cache_cacheable_headers()
> gets called with r->headers_out instead of headers_out?

Missed this one :-).

http://svn.apache.org/viewvc?view=rev&revision=649793

Regards

RĂ¼diger

Mime
View raw message