httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Eric Covener <cove...@gmail.com>
Subject Re: Serving filenames with wildcards using mod_proxy_ftp
Date Fri, 27 Feb 2009 20:04:10 GMT
On Tue, Feb 24, 2009 at 10:29 AM, Dan Poirier <poirier@pobox.com> wrote:
>  The ProxyFtpListOnWildcard directive controls whether wildcard
>  characters ("*?[{~") in requested filenames cause mod_proxy_ftp to
>  return a listing of files instead of downloading a file.  By default
>  (value on), they do.  Set to "off" to allow downloading files even
>  if they have wildcard characters in their names.  (directory
>  context)

Looks reasonable

>
> I'd appreciate comments on this approach, and my proposed
> implementation (patch against trunk is attached).
>
> Also, in testing that change, I found that mod_proxy_ftp escapes
> wildcards in filenames using backslashes when sending them to the FTP
> server, which none of the FTP servers I was testing with understood.
> To continue with my testing, I added another directive to turn that
> behavior off, but I'd like to better understand why that behavior is
> there, since it appears to assume a behavior that my FTP servers don't
> have, and doesn't seem to be mentioned in RFC 959.
>

What backends/results did you try?  Does anyone have any anecdotal
experience about what backends might require escaping of the glob
characters on a retrieve?

I'm wondering if we add the feature, should we flip the default in trunk?

-- 
Eric Covener
covener@gmail.com

Mime
View raw message