Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 68725 invoked from network); 6 Jan 2009 15:14:38 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 6 Jan 2009 15:14:38 -0000 Received: (qmail 68240 invoked by uid 500); 6 Jan 2009 15:14:34 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 68187 invoked by uid 500); 6 Jan 2009 15:14:34 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 68178 invoked by uid 99); 6 Jan 2009 15:14:34 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Jan 2009 07:14:34 -0800 X-ASF-Spam-Status: No, hits=2.2 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of trawick@gmail.com designates 209.85.217.11 as permitted sender) Received: from [209.85.217.11] (HELO mail-gx0-f11.google.com) (209.85.217.11) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Jan 2009 15:14:26 +0000 Received: by gxk4 with SMTP id 4so5497396gxk.0 for ; Tue, 06 Jan 2009 07:14:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:in-reply-to:mime-version:content-type:references; bh=HbkSw/aHgXnZhNskhDGnydf9t0Al0sOXM/AS19HDIOE=; b=RfyA8SJmxtR/SUpe2i/NZu/nlPrEzFt/iNkhkBY9I/c5lo1DDShTaHniZ1xcLAt5zE CSuw+slo9lBNIG3AHlYNRPnsEVMQPVNmQYEHA09xeG9wMKjZ3+DoLzCz2v4rSz120nyu Dakzt1+ZMOWPGJorY0BRdtn21bD0XbnlGt9Oc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version :content-type:references; b=x+ZW21hRD/AU+N3LP0FGnZ81TnQ338JyupJP4B3lrjpSV15TqNG/vcP8WvXkCHfqQg +Ps9K84B7bXXQeyD2pSfhOWCWe0tWPUexpgBmx2jeipbYi5czQ9un9kHJGvKi2orZ0aW 5K/FHFaIsG1l4MRJpwbj1t7jUjdQL1IbBBjb8= Received: by 10.143.4.11 with SMTP id g11mr9195039wfi.340.1231254844370; Tue, 06 Jan 2009 07:14:04 -0800 (PST) Received: by 10.143.7.20 with HTTP; Tue, 6 Jan 2009 07:14:03 -0800 (PST) Message-ID: Date: Tue, 6 Jan 2009 10:14:03 -0500 From: "Jeff Trawick" To: dev@httpd.apache.org Subject: Re: svn commit: r731965 - /httpd/httpd/trunk/modules/generators/mod_cgid.c In-Reply-To: <20090106150535.3691123888A5@eris.apache.org> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_190687_28475030.1231254844365" References: <20090106150535.3691123888A5@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org ------=_Part_190687_28475030.1231254844365 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline On Tue, Jan 6, 2009 at 10:05 AM, wrote: > Author: trawick > Date: Tue Jan 6 07:05:33 2009 > New Revision: 731965 > > URL: http://svn.apache.org/viewvc?rev=731965&view=rev > Log: > the length arguments are apr_size_t, not int > > Modified: > httpd/httpd/trunk/modules/generators/mod_cgid.c > > Modified: httpd/httpd/trunk/modules/generators/mod_cgid.c > URL: > http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/generators/mod_cgid.c?rev=731965&r1=731964&r2=731965&view=diff > > ============================================================================== > --- httpd/httpd/trunk/modules/generators/mod_cgid.c (original) > +++ httpd/httpd/trunk/modules/generators/mod_cgid.c Tue Jan 6 07:05:33 > 2009 > @@ -354,7 +354,7 @@ > va_start(ap, count); > for (i = 0; i < count; i++) { > vec[i].iov_base = va_arg(ap, caddr_t); > - vec[i].iov_len = va_arg(ap, int); > + vec[i].iov_len = va_arg(ap, apr_size_t); IIRC, size_t is 64-bit with a 64-bit build on AIX; someone with access to the right bits (and bored out of their skull) could look for some fun behavior with the original code ------=_Part_190687_28475030.1231254844365 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline On Tue, Jan 6, 2009 at 10:05 AM, <trawick@apache.org> wrote:
Author: trawick
Date: Tue Jan  6 07:05:33 2009
New Revision: 731965

URL: http://svn.apache.org/viewvc?rev=731965&view=rev
Log:
the length arguments are apr_size_t, not int

Modified:
   httpd/httpd/trunk/modules/generators/mod_cgid.c

Modified: httpd/httpd/trunk/modules/generators/mod_cgid.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/generators/mod_cgid.c?rev=731965&r1=731964&r2=731965&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/generators/mod_cgid.c (original)
+++ httpd/httpd/trunk/modules/generators/mod_cgid.c Tue Jan  6 07:05:33 2009
@@ -354,7 +354,7 @@
    va_start(ap, count);
    for (i = 0; i < count; i++) {
        vec[i].iov_base = va_arg(ap, caddr_t);
-        vec[i].iov_len  = va_arg(ap, int);
+        vec[i].iov_len  = va_arg(ap, apr_size_t);

IIRC, size_t is 64-bit with a 64-bit build on AIX; someone with access to the right bits (and bored out of their skull) could look for some fun behavior with the original code

------=_Part_190687_28475030.1231254844365--