Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: neutral (nike.apache.org: local policy)
Message-ID: <496223B4.3060508@webthing.com>
Date: Mon, 05 Jan 2009 15:13:56 +0000
From: Nick Kew <nick@webthing.com>
User-Agent: Thunderbird 2.0.0.17 (X11/20081023)
MIME-Version: 1.0
To: dev@httpd.apache.org
Subject: Re: svn commit: r731358 - in /httpd/httpd/trunk: CHANGES
 docs/manual/mod/mod_ext_filter.xml
 modules/filters/mod_ext_filter.c
References: <20090104205242.471C5238899E@eris.apache.org>
 <4961E048.1050800@apache.org> <4962081B.6070502@webthing.com>
 <49621F74.6020405@apache.org>
In-Reply-To: <49621F74.6020405@apache.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Ruediger Pluem wrote:
> 
> On 01/05/2009 02:16 PM, Nick Kew wrote:
>> Ruediger Pluem wrote:
>>
>>> Hm. I am slightly confused here. The documentation states that "abort"
>>> should be
>>> the default behaviour (that is the else branch), but if nothing is set
>>> in the config
>>> onfail defaults to -1 which would cause to get us here (the remove case).
>>> So either the documentation or the code is wrong.
>> Fixed in r731388, which is included in the backport proposal.
>> Thanks for reviewing.
> 
> IMHO r731388 does not fix my concern. The concern I have is that documentation
> and code are contrary on what is the default behaviour if nothing is set.

Aaargh!

OK, my local copy is changed to testing (ctx->dc->onfail == 1).
It seems that got omitted from my commit, so you're right.
Fixing it now!

(the difference arose because the local copy has an experimental
variant in with #ifdef, and I couldn't be arsed to tidy all that up).

-- 
Nick Kew