Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 43167 invoked from network); 5 Jan 2009 13:15:58 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 5 Jan 2009 13:15:58 -0000 Received: (qmail 94523 invoked by uid 500); 5 Jan 2009 13:15:51 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 94469 invoked by uid 500); 5 Jan 2009 13:15:50 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 94460 invoked by uid 99); 5 Jan 2009 13:15:50 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Jan 2009 05:15:50 -0800 X-ASF-Spam-Status: No, hits=1.2 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [80.229.52.226] (HELO opensolaris.local) (80.229.52.226) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Jan 2009 13:15:43 +0000 Received: from [127.0.0.1] (opensolaris [127.0.0.1]) by opensolaris.local (8.14.3+Sun/8.14.3) with ESMTP id n05DGBCj000796 for ; Mon, 5 Jan 2009 13:16:12 GMT Message-ID: <4962081B.6070502@webthing.com> Date: Mon, 05 Jan 2009 13:16:11 +0000 From: Nick Kew User-Agent: Thunderbird 2.0.0.17 (X11/20081023) MIME-Version: 1.0 To: dev@httpd.apache.org Subject: Re: svn commit: r731358 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_ext_filter.xml modules/filters/mod_ext_filter.c References: <20090104205242.471C5238899E@eris.apache.org> <4961E048.1050800@apache.org> In-Reply-To: <4961E048.1050800@apache.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Ruediger Pluem wrote: > Hm. I am slightly confused here. The documentation states that "abort" should be > the default behaviour (that is the else branch), but if nothing is set in the config > onfail defaults to -1 which would cause to get us here (the remove case). > So either the documentation or the code is wrong. Fixed in r731388, which is included in the backport proposal. Thanks for reviewing. -- Nick Kew