httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nick Kew <n...@webthing.com>
Subject Re: svn commit: r731358 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_ext_filter.xml modules/filters/mod_ext_filter.c
Date Mon, 05 Jan 2009 15:13:56 GMT
Ruediger Pluem wrote:
> 
> On 01/05/2009 02:16 PM, Nick Kew wrote:
>> Ruediger Pluem wrote:
>>
>>> Hm. I am slightly confused here. The documentation states that "abort"
>>> should be
>>> the default behaviour (that is the else branch), but if nothing is set
>>> in the config
>>> onfail defaults to -1 which would cause to get us here (the remove case).
>>> So either the documentation or the code is wrong.
>> Fixed in r731388, which is included in the backport proposal.
>> Thanks for reviewing.
> 
> IMHO r731388 does not fix my concern. The concern I have is that documentation
> and code are contrary on what is the default behaviour if nothing is set.

Aaargh!

OK, my local copy is changed to testing (ctx->dc->onfail == 1).
It seems that got omitted from my commit, so you're right.
Fixing it now!

(the difference arose because the local copy has an experimental
variant in with #ifdef, and I couldn't be arsed to tidy all that up).

-- 
Nick Kew

Mime
View raw message