httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ruediger Pluem <rpl...@apache.org>
Subject Re: svn commit: r731358 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_ext_filter.xml modules/filters/mod_ext_filter.c
Date Mon, 05 Jan 2009 14:55:48 GMT


On 01/05/2009 02:16 PM, Nick Kew wrote:
> Ruediger Pluem wrote:
> 
>> Hm. I am slightly confused here. The documentation states that "abort"
>> should be
>> the default behaviour (that is the else branch), but if nothing is set
>> in the config
>> onfail defaults to -1 which would cause to get us here (the remove case).
>> So either the documentation or the code is wrong.
> 
> Fixed in r731388, which is included in the backport proposal.
> Thanks for reviewing.

IMHO r731388 does not fix my concern. The concern I have is that documentation
and code are contrary on what is the default behaviour if nothing is set.

Regards

RĂ¼diger



Mime
View raw message