Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 63892 invoked from network); 1 Dec 2008 14:33:22 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 1 Dec 2008 14:33:22 -0000 Received: (qmail 54433 invoked by uid 500); 1 Dec 2008 14:33:30 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 54371 invoked by uid 500); 1 Dec 2008 14:33:29 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 54362 invoked by uid 99); 1 Dec 2008 14:33:29 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Dec 2008 06:33:29 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of covener@gmail.com designates 74.125.46.152 as permitted sender) Received: from [74.125.46.152] (HELO yw-out-1718.google.com) (74.125.46.152) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Dec 2008 14:32:02 +0000 Received: by yw-out-1718.google.com with SMTP id 6so955750ywa.84 for ; Mon, 01 Dec 2008 06:32:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=+w22UV/IIqn0VwDpRyGN6Xjehmoe6ie91TrL/5L3NSo=; b=P0ee6ri4103AXHvZB/jH4FQm/CMzH5fP2z4ZywKseG137CuypJWhqrFNoWuvBpnR0H uguEXKFuFpCfG1WeVSqqmfCphX5b8yJSanMO72fQlridhmf7y9NQB8ra2vJMqzLKLAbU sHnqyqFN+QHRhK/nv4o+g8jS7BRZptPpruvi4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=doh9IKQpkpr6+wwUPCNffLDa/ME/TN+i2vfdXtg4iPYkNcO3dsQJURuXH2TdXp0MvM wH4zpZK39FU76iIliNz7cWsoprufCEM22W5g501beQfAdAzZZN9i7iFBdC4VLWSrD+8x S2jyavOChaN1RjK2MFKWBORO6gwN9WBAsK6cw= Received: by 10.151.48.15 with SMTP id a15mr5058858ybk.189.1228141968729; Mon, 01 Dec 2008 06:32:48 -0800 (PST) Received: by 10.150.50.9 with HTTP; Mon, 1 Dec 2008 06:32:48 -0800 (PST) Message-ID: <1404e5910812010632x67adef70y9d9ffab1e4cbf2b3@mail.gmail.com> Date: Mon, 1 Dec 2008 09:32:48 -0500 From: "Eric Covener" To: dev@httpd.apache.org Subject: Re: Handling AP_FILTER_ERROR In-Reply-To: <1404e5910812010433r27d86ba8m95803275bc89024c@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20081130222025.360e755e@grimnir> <1404e5910811301522r4fc8c748h205b5f9a9b7d8096@mail.gmail.com> <20081130234250.168ac801@grimnir> <4933A5D2.4070807@apache.org> <4933AEE3.7030703@apache.org> <4933BA29.9010905@apache.org> <1404e5910812010433r27d86ba8m95803275bc89024c@mail.gmail.com> X-Virus-Checked: Checked by ClamAV on apache.org On Mon, Dec 1, 2008 at 7:33 AM, Eric Covener wrote: > On Mon, Dec 1, 2008 at 6:44 AM, Nick Kew wrote: >> >> On 1 Dec 2008, at 10:19, Ruediger Pluem wrote: >> >>> if (eb) { >>> - ap_die(eb->status, r); >>> + int status; >>> + >>> + status = eb->status; >>> + apr_brigade_cleanup(b); >>> + ap_die(status, r); >>> return AP_FILTER_ERROR; >>> } >> >> Good call. +1 to that. > > I'll revisit this afternoon, add to the backport, and reset the voting. > Committed in r722081 with no change in perl framework. -- Eric Covener covener@gmail.com