httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nick Kew <n...@webthing.com>
Subject Re: Handling AP_FILTER_ERROR
Date Mon, 01 Dec 2008 10:01:25 GMT

On 1 Dec 2008, at 09:31, Ruediger Pluem wrote:
>>
>> But do you see any objection to the (IMHO simpler) fix of
>> removing error buckets as we detect them?
>
> Not directly. Could you please propose a concrete patch?
> It makes discussion easier :-).

I think the one-liner should work, since we don't re-use the error  
bucket.
So against trunk, that's:

--- modules/http/http_filters.c (revision 722000)
+++ modules/http/http_filters.c (working copy)
@@ -1133,6 +1133,7 @@
      {
          if (AP_BUCKET_IS_ERROR(e) && !eb) {
              eb = e->data;
+            apr_bucket_delete(e);
              continue;
          }
          /*

-- 
Nick Kew

Mime
View raw message