httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ruediger Pluem <rpl...@apache.org>
Subject Re: svn commit: r726068 - /httpd/httpd/trunk/modules/proxy/Makefile.in
Date Fri, 12 Dec 2008 22:45:44 GMT


On 12/12/2008 11:31 PM, Ruediger Pluem wrote:
> 
> On 12/12/2008 11:10 PM, Ruediger Pluem wrote:
>> On 12/12/2008 05:31 PM, jim@apache.org wrote:
>>> Author: jim
>>> Date: Fri Dec 12 08:31:15 2008
>>> New Revision: 726068
>>>
>>> URL: http://svn.apache.org/viewvc?rev=726068&view=rev
>>> Log:
>>> Treat proxy/balancers normally and independently...
>>> also, allow nice pretty
>>>
>>>    Making all in proxy
>>>      ...
>>>    Making all in proxy/balancers
>>>
>>>
>>> Modified:
>>>     httpd/httpd/trunk/modules/proxy/Makefile.in
>>>
>>> Modified: httpd/httpd/trunk/modules/proxy/Makefile.in
>>> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/Makefile.in?rev=726068&r1=726067&r2=726068&view=diff
>>> ==============================================================================
>>> --- httpd/httpd/trunk/modules/proxy/Makefile.in (original)
>>> +++ httpd/httpd/trunk/modules/proxy/Makefile.in Fri Dec 12 08:31:15 2008
>>> @@ -1,4 +1,4 @@
>>>  # a modules Makefile has no explicit targets -- they will be defined by
>>>  # whatever modules are enabled. just grab special.mk to deal with this.
>>> -SUBDIRS = balancers
>>> +#SUBDIRS = balancers
>>>  include $(top_srcdir)/build/special.mk
>> Hm, this seems to have broken compilation of the balancer modules. It seems they
>> do not get compiled any longer.
> 
> This does not seem to be the reason. Must be something different. Digging...

The following patch seems to fix this:

Index: modules/proxy/balancers/config2.m4
===================================================================
--- modules/proxy/balancers/config2.m4  (Revision 726122)
+++ modules/proxy/balancers/config2.m4  (Arbeitskopie)
@@ -1,11 +1,4 @@
 APACHE_MODPATH_INIT(proxy/balancers)
-if test "$enable_proxy" = "shared"; then
-  proxy_mods_enable=shared
-elif test "$enable_proxy" = "yes"; then
-  proxy_mods_enable=yes
-else
-  proxy_mods_enable=no
-fi

 proxy_lb_br_objs="mod_lbmethod_byrequests.lo"
 proxy_lb_bt_objs="mod_lbmethod_bytraffic.lo"


The reason is that $enable_proxy is empty by the point of time the above is
executed. Since the proxy modules get configured earlier we know that
proxy_mods_enable should already have a sane value. But I am no build
system specialist. So some remote eyes please,

Regards

RĂ¼diger


Mime
View raw message