httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ruediger Pluem <rpl...@apache.org>
Subject Re: Handling AP_FILTER_ERROR
Date Mon, 01 Dec 2008 09:31:15 GMT


On 12/01/2008 10:02 AM, Nick Kew wrote:
> 
> On 1 Dec 2008, at 08:52, Ruediger Pluem wrote:
>>
>> 2. IMHO ap_invoke_handler is only called in three locations:
> 
> It's a public API, so could be called by any module.

Correct.

> 
>> So ap_die maybe should do the following:
>>
>>     if (type == AP_FILTER_ERROR) {
>>         if [ap_http_header_filter is still in chain] {
>>            log this
>>            type = HTTP_INTERNAL_SERVER_ERROR;
>>         }
>>         else {
>>            return;
>>         }
>>     }
> 
> That looks good, too.
> 
> But do you see any objection to the (IMHO simpler) fix of
> removing error buckets as we detect them?

Not directly. Could you please propose a concrete patch?
It makes discussion easier :-).

Regards

RĂ¼diger



Mime
View raw message