httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Graham Leggett <minf...@sharp.fm>
Subject Re: svn commit: r718082 - /httpd/httpd/trunk/modules/filters/mod_buffer.c
Date Sun, 16 Nov 2008 22:35:33 GMT
Ruediger Pluem wrote:

>> +                /* pass flush and metadata buckets through */
>> +                if (APR_BUCKET_IS_FLUSH(e) || APR_BUCKET_IS_METADATA(e)) {
> 
> This is redundant as flush buckets are metadata buckets :-).
> 
>> +                    APR_BUCKET_REMOVE(e);
>> +                    APR_BRIGADE_INSERT_TAIL(bb, e);
>> +                    continue;
>> +                }

Hmmm... true. A metadata bucket should be passed over into the buffer, 
but flush buckets should cause the buffer to be read straight away. Will 
fix.

Regards,
Graham
--

Mime
View raw message