httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rainer Jung <rainer.j...@kippdata.de>
Subject Re: SSL toolkit detection in acinclude.m4
Date Thu, 06 Nov 2008 15:33:33 GMT
Plüm, Rüdiger, VF-Group schrieb:
>  
> 
>> -----Ursprüngliche Nachricht-----
>> Von: "Plüm, Rüdiger, VF-Group" 
>> Gesendet: Dienstag, 4. November 2008 13:24
>> An: dev@httpd.apache.org
>> Betreff: Re: SSL toolkit detection in acinclude.m4
>>
>>  
>>
>>> -----Ursprüngliche Nachricht-----
>>> Von: Ruediger Pluem 
>>> Gesendet: Samstag, 25. Oktober 2008 15:18
>>> An: dev@httpd.apache.org
>>> Betreff: Re: SSL toolkit detection in acinclude.m4
>>>
>>>
>>>
>>> On 10/16/2008 12:04 PM, Rainer Jung wrote:
>>>> Ruediger Pluem wrote:
>>>>> While investigating PR46018 I came across the following in 
>>> acinclude.m4
>>>>>   dnl Run header and version checks
>>>>>   saved_CPPFLAGS="$CPPFLAGS"
>>>>>   saved_LIBS="$LIBS"
>>>>>   if test "x$ap_ssltk_base" != "x"; then
>>>>>     APR_ADDTO(CPPFLAGS, [-I$ap_ssltk_base/include])
>>>>>     APR_ADDTO(INCLUDES, [-I$ap_ssltk_base/include])
>>>>>     APR_ADDTO(LDFLAGS, [-L$ap_ssltk_base/lib])
>>>>>
>>>>>
>>>>> Is there any reason why we only save / restore CPPFLAGS 
>>> and LIBS and
>>>>> not INCLUDES and LDFLAGS which are also modified?
>>>>>
>>>>> The next thing I don't get is why we do not add 
>>> `$apr_config --libs`
>>>>> to LIBS
>>>>> any longer (since r669924). This causes -ldl to miss and thus the
>>>>> checks to fail
>>>>> (I guess only if there is no pkgconfig file).
>>>> Yes, I ran into a similar issue, when compiling 2.2.10 
>>> against static
>>>> openssl libs on Solaris, having no pkgconfig. Then you need 
>>> to add -ldl,
>>>> -lnsl, -lsocket during the configure tests, because 
>>> otherwise tehy fail.
>>>> That was not necessary until 2.2.9.
>>> Any further comments, ideas how to fix this?
>> I added a possible fix to the PR 
>> (https://issues.apache.org/bugzilla/attachment.cgi?id=22826).
>> Does somebody mind checking if this is the correct thing to do?
> 
> Rainer does the patch fix your issues on Solaris?

I'm in New Orleans. Will be able to test remotely but only later. Will
report back in 24 hours.

Regards,

Rainer

Mime
View raw message