httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ruediger Pluem <rpl...@apache.org>
Subject Re: svn commit: r709553 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_authn_core.xml modules/aaa/mod_authn_core.c
Date Sat, 01 Nov 2008 11:27:21 GMT


On 10/31/2008 09:26 PM, André Malo wrote:
> * chrisd@apache.org wrote:
> 
>> Author: chrisd
>> Date: Fri Oct 31 13:18:07 2008
>> New Revision: 709553
>>
>> URL: http://svn.apache.org/viewvc?rev=709553&view=rev
>> Log:
>> Add AuthType of None to support disabling authentication.
>> Prevent crash when provider alias created to provider which is not
>> yet registered.
>> Migrate remaining functionality of mod_authn_default to mod_authn_core.
> 
> While this sounds nice...
> could you please split such changes into atomic commits? One issue - one 
> commit. You also committed docs changes you didn't mention in the log 
> message.
> 
> I'm not sure if the crash fix shouldn't go into CHANGES.

Plus it makes it really hard to read the diffs if you mix formating changes
with functional changes. Please separate them.

Regards

RĂ¼diger

Mime
View raw message