httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ruediger Pluem <rpl...@apache.org>
Subject Re: svn commit: r697357 - in /httpd/httpd/trunk: include/ modules/http/ modules/test/ server/ server/mpm/experimental/event/
Date Tue, 21 Oct 2008 09:50:17 GMT


On 10/21/2008 01:09 AM, Nick Kew wrote:
> pquerna@apache.org wrote:
> 
>> --- httpd/httpd/trunk/modules/http/http_request.c (original)
>> +++ httpd/httpd/trunk/modules/http/http_request.c Sat Sep 20 04:58:08
>> 2008
> 
>> @@ -257,24 +297,7 @@
>>          ap_die(access_status, r);
>>      }
>>  
>> -    /* Send an EOR bucket through the output filter chain.  When
>> -     * this bucket is destroyed, the request will be logged and
>> -     * its pool will be freed
>> -     */
>> -    bb = apr_brigade_create(r->connection->pool,
>> r->connection->bucket_alloc);
>> -    b = ap_bucket_eor_create(r->connection->bucket_alloc, r);
>> -    APR_BRIGADE_INSERT_HEAD(bb, b);
>> -    ap_pass_brigade(r->connection->output_filters, bb);
>> -
>> -    /* From here onward, it is no longer safe to reference r
>> -     * or r->pool, because r->pool may have been destroyed
>> -     * already by the EOR bucket's cleanup function.
>> -     */
>> -
>> -    c->cs->state = CONN_STATE_WRITE_COMPLETION;
>> -    check_pipeline(c);
>> -    if (ap_extended_status)
>> -        ap_time_process_request(c->sbh, STOP_PREQUEST);
>> +    return ap_process_request_after_handler(r);
>>  }
> 
> This is a compile error in a void function.
> What exactly was intended here?

As ap_process_request_after_handler is a void function by itself I guess it
should be simply

ap_process_request_after_handler(r);

instead of

return ap_process_request_after_handler(r);

but this is just a guess.

Regards

RĂ¼diger

> 

Mime
View raw message