Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: neutral (athena.apache.org: local policy)
Message-ID: <48DDE09A.5060802@apache.org>
Date: Sat, 27 Sep 2008 09:28:26 +0200
From: Mladen Turk <mturk@apache.org>
User-Agent: Thunderbird 2.0.0.14 (X11/20080515)
MIME-Version: 1.0
To: dev@httpd.apache.org
Subject: Re: svn commit: r699481 - /httpd/httpd/trunk/server/mpm/winnt/child.c
References: <20080926201510.F2417238889E@eris.apache.org>
In-Reply-To: <20080926201510.F2417238889E@eris.apache.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

wrowe@apache.org wrote:
> Author: wrowe
> Date: Fri Sep 26 13:15:10 2008
> New Revision: 699481
> 
> URL: http://svn.apache.org/viewvc?rev=699481&view=rev
> Log:
> Reimplement ThreadStackSize to behave as on unix for any
> Windows 2003/2008 (XP/Vista) servers.  Virtual allocations
> will only consume pages once referenced, while the page
> alignment will vary by ThreadStackSize setting so that the
> maximum number of threads and minimum stack VM profile will
> be wasted.
> 
> -            child_handles[i] = (HANDLE) _beginthreadex(

> +            child_handles[i] = CreateThread(NULL, ap_thread_stacksize,

Why did you change the _beginthreadex to CreateThread?
Won't that bring back CRT local Tls problems that forced using
_beginthreadex at the first place?

Also I have concerns with chosen 64K thread stack size for
some other threads in this patch series. Perhaps a 256K will
be more safe (particularly for winnt_accept), because 64K on
stack overflow OS will allocate 1M actually, so this either needs to
get carefully calculated or traced by some tool, cause larger
initial commit size might eventually use less memory.

Regards
-- 
^(TM)