Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: neutral (athena.apache.org: local policy)
Message-ID: <48DC3CF5.1070507@rowe-clan.net>
Date: Thu, 25 Sep 2008 20:37:57 -0500
From: "William A. Rowe, Jr." <wrowe@rowe-clan.net>
User-Agent: Thunderbird 2.0.0.16 (X11/20080723)
MIME-Version: 1.0
To: dev@httpd.apache.org
Subject: Re: [PATCH] add ap_sendfile_enabled
References: <C501AEB3.B41AE%Brian.Akins@turner.com>
In-Reply-To: <C501AEB3.B41AE%Brian.Akins@turner.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Akins, Brian wrote:
> 
>  int ap_feature_enabled(request_rec *r, server_rec *s, int features)
> 
>  if(ap_feature_enabled(r, NULL, SENDFILE)) {
>     blah...
>  }

Couple of points, API fn name sucks, can it be ap_request_config_test(r,feat)?

Always request-rec based, there should be no need for server rec (two args
are faster than 3).

About your other idea, it's a no-go.  You would have to perform a subrequest
to determine the entire config parsing, before then testing the feature.
It's so expensive, it's misleading to shorthand it into a single function.

But I don't know that you need to (for adding buckets from multiple files)
unless you want the added complexity of adding sendfile buckets.

Bill