Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 12949 invoked from network); 20 Sep 2008 21:42:06 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 20 Sep 2008 21:42:06 -0000 Received: (qmail 28125 invoked by uid 500); 20 Sep 2008 21:41:56 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 28071 invoked by uid 500); 20 Sep 2008 21:41:56 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 28062 invoked by uid 99); 20 Sep 2008 21:41:56 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 20 Sep 2008 14:41:56 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.9] (HELO minotaur.apache.org) (140.211.11.9) by apache.org (qpsmtpd/0.29) with SMTP; Sat, 20 Sep 2008 21:41:05 +0000 Received: (qmail 12499 invoked by uid 2161); 20 Sep 2008 21:41:38 -0000 Received: from [192.168.2.4] (euler.heimnetz.de [192.168.2.4]) by cerberus.heimnetz.de (Postfix on SuSE Linux 7.0 (i386)) with ESMTP id 80BC71721C for ; Sat, 20 Sep 2008 23:41:29 +0200 (CEST) Message-ID: <48D56E0B.3080003@apache.org> Date: Sat, 20 Sep 2008 23:41:31 +0200 From: Ruediger Pluem User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.16) Gecko/20080702 SeaMonkey/1.1.11 MIME-Version: 1.0 To: dev@httpd.apache.org Subject: Re: svn commit: r697357 - in /httpd/httpd/trunk: include/ modules/http/ modules/test/ server/ server/mpm/experimental/event/ References: <20080920115809.A489923889C2@eris.apache.org> In-Reply-To: <20080920115809.A489923889C2@eris.apache.org> X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Checked: Checked by ClamAV on apache.org On 09/20/2008 01:58 PM, pquerna@apache.org wrote: > Author: pquerna > Date: Sat Sep 20 04:58:08 2008 > New Revision: 697357 > > URL: http://svn.apache.org/viewvc?rev=697357&view=rev > Log: > Introduce Suspendable Requests to the Event MPM. > > Modified: httpd/httpd/trunk/include/ap_mpm.h > URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/include/ap_mpm.h?rev=697357&r1=697356&r2=697357&view=diff > ============================================================================== > --- httpd/httpd/trunk/include/ap_mpm.h (original) > +++ httpd/httpd/trunk/include/ap_mpm.h Sat Sep 20 04:58:08 2008 > @@ -152,6 +152,14 @@ > */ > AP_DECLARE(apr_status_t) ap_mpm_query(int query_code, int *result); > > + > +typedef void (ap_mpm_callback_fn_t)(void *baton); > + > +/* XXXXXXX: only added support in the Event MPM.... */ > +AP_DECLARE(void) ap_mpm_register_timed_callback(apr_time_t t, > + ap_mpm_callback_fn_t *cbfn, > + void *baton); > + This breaks compilation of other MPMs as exports is created from all prototypes found in all header files in include. So IMHO the implementation of ap_mpm_register_timed_callback either has to move to mpm_common.c or we need to add dummy implementation for the other MPM's. Or we have a dummy implementation in mpm_common.c that is in a conditional block and that only gets compiled if the MPM is not the event MPM. Regards Rüdiger