On Sat, Sep 6, 2008 at 4:38 AM, Ruediger Pluem <rpluem@apache.org> wrote:

+    bb = apr_brigade_create(r->pool, c->bucket_alloc);

This is bad. Please store the brigade in the filter context and reuse it,
by cleaning it. See also http://httpd.apache.org/docs/trunk/en/developer/output-filters.html#filtering

I committed Dan's latest patch as r693564 which reuses the brigade as suggested.

The same error is in send_downstream and IMHO they can share the same brigade.

Dan plans to merge code to take care of that, but not in this patch for ease of review.

Greg