httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Greg Ames" <ames.g...@gmail.com>
Subject Re: svn commit: r692567 - /httpd/httpd/trunk/modules/filters/mod_charset_lite.c
Date Tue, 09 Sep 2008 19:08:45 GMT
On Sat, Sep 6, 2008 at 4:38 AM, Ruediger Pluem <rpluem@apache.org> wrote:

>
>> +    bb = apr_brigade_create(r->pool, c->bucket_alloc);
>>
>
> This is bad. Please store the brigade in the filter context and reuse it,
> by cleaning it. See also
> http://httpd.apache.org/docs/trunk/en/developer/output-filters.html#filtering


I committed Dan's latest patch as r693564 which reuses the brigade as
suggested.

<http://httpd.apache.org/docs/trunk/en/developer/output-filters.html#filtering>

> The same error is in send_downstream and IMHO they can share the same
> brigade.


Dan plans to merge code to take care of that, but not in this patch for ease
of review.

Greg

Mime
View raw message