httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akins, Brian" <Brian.Ak...@turner.com>
Subject Re: [PATCH] add ap_sendfile_enabled
Date Thu, 25 Sep 2008 18:32:49 GMT
On 9/25/08 2:24 PM, "William A. Rowe, Jr." <wrowe@rowe-clan.net> wrote:

> Hmmm... -0.9, it's private because the connection mechanics are private.
> Core transport is part of core.
> 
> What was the rational?

Bcs lots of modules have things like this.  Using mod_dialup as an example:

/* to detect sendfile enabled, we need CORE_PRIVATE. Someone should fix
this. */
#define CORE_PRIVATE
#include "http_core.h"
...
core_dir_config *ccfg = ap_get_module_config(r->per_dir_config,
                                                     &core_module);
...
   rv = apr_file_open(&fd, r->filename, APR_READ | APR_BINARY
#if APR_HAS_SENDFILE
                           | ((ccfg->enable_sendfile == ENABLE_SENDFILE_OFF)
                              ? 0 : APR_SENDFILE_ENABLED)
#endif
                       , 0, r->pool);

  


-- 
Brian Akins
Chief Operations Engineer
Turner Digital Media Technologies


Mime
View raw message