httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: [PATCH] add ap_sendfile_enabled
Date Fri, 26 Sep 2008 01:37:57 GMT
Akins, Brian wrote:
> 
>  int ap_feature_enabled(request_rec *r, server_rec *s, int features)
> 
>  if(ap_feature_enabled(r, NULL, SENDFILE)) {
>     blah...
>  }

Couple of points, API fn name sucks, can it be ap_request_config_test(r,feat)?

Always request-rec based, there should be no need for server rec (two args
are faster than 3).

About your other idea, it's a no-go.  You would have to perform a subrequest
to determine the entire config parsing, before then testing the feature.
It's so expensive, it's misleading to shorthand it into a single function.

But I don't know that you need to (for adding buckets from multiple files)
unless you want the added complexity of adding sendfile buckets.

Bill

Mime
View raw message