httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ruediger Pluem <rpl...@apache.org>
Subject Re: svn commit: r697357 - in /httpd/httpd/trunk: include/ modules/http/ modules/test/ server/ server/mpm/experimental/event/
Date Sat, 20 Sep 2008 21:41:31 GMT


On 09/20/2008 01:58 PM, pquerna@apache.org wrote:
> Author: pquerna
> Date: Sat Sep 20 04:58:08 2008
> New Revision: 697357
> 
> URL: http://svn.apache.org/viewvc?rev=697357&view=rev
> Log:
> Introduce Suspendable Requests to the Event MPM.
> 

> Modified: httpd/httpd/trunk/include/ap_mpm.h
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/include/ap_mpm.h?rev=697357&r1=697356&r2=697357&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/include/ap_mpm.h (original)
> +++ httpd/httpd/trunk/include/ap_mpm.h Sat Sep 20 04:58:08 2008
> @@ -152,6 +152,14 @@
>   */
>  AP_DECLARE(apr_status_t) ap_mpm_query(int query_code, int *result);
>  
> +
> +typedef void (ap_mpm_callback_fn_t)(void *baton);
> +
> +/* XXXXXXX: only added support in the Event MPM.... */
> +AP_DECLARE(void) ap_mpm_register_timed_callback(apr_time_t t,
> +                                                ap_mpm_callback_fn_t *cbfn,
> +                                                void *baton);
> +    

This breaks compilation of other MPMs as exports is created from all prototypes found in all
header files in include. So IMHO the implementation of ap_mpm_register_timed_callback either
has
to move to mpm_common.c or we need to add dummy implementation for the other MPM's.
Or we have a dummy implementation in mpm_common.c that is in a conditional block and that
only
gets compiled if the MPM is not the event MPM.

Regards

RĂ¼diger



Mime
View raw message