httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: svn commit: r697357 - in /httpd/httpd/trunk: include/ modules/http/ modules/test/ server/ server/mpm/experimental/event/
Date Sun, 21 Sep 2008 16:40:32 GMT

On Sep 20, 2008, at 4:31 PM, Paul Querna wrote:

> Jim Jagielski wrote:
>> On Sat, Sep 20, 2008 at 11:58:09AM -0000, pquerna@apache.org wrote:
>>> -#define ap_queue_empty(queue) ((queue)->nelts == 0)
>>> +#define ap_queue_empty(queue) ((queue)->nelts == 0 &&  
>>> APR_RING_EMPTY(&queue->timers ,timer_event_t, link))
>> Not || ?
>
> Don't think so?
>
> You want to return true if there are both zero entries in the array,  
> and zero in the ring.
>
> And false if either has something in it.
>

Ahhh yes, we need to check both structs in the queue now.

Mime
View raw message