Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 79670 invoked from network); 4 Aug 2008 14:00:15 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 4 Aug 2008 14:00:15 -0000 Received: (qmail 31048 invoked by uid 500); 4 Aug 2008 14:00:07 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 30974 invoked by uid 500); 4 Aug 2008 14:00:07 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 30963 invoked by uid 99); 4 Aug 2008 14:00:07 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Aug 2008 07:00:07 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.9] (HELO minotaur.apache.org) (140.211.11.9) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 04 Aug 2008 13:59:20 +0000 Received: (qmail 79170 invoked by uid 2161); 4 Aug 2008 13:59:47 -0000 Received: from [192.168.2.4] (euler.heimnetz.de [192.168.2.4]) by cerberus.heimnetz.de (Postfix on SuSE Linux 7.0 (i386)) with ESMTP id 353DE1721C for ; Mon, 4 Aug 2008 15:59:37 +0200 (CEST) Message-ID: <48970B50.3040608@apache.org> Date: Mon, 04 Aug 2008 15:59:44 +0200 From: Ruediger Pluem User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.16) Gecko/20080702 SeaMonkey/1.1.11 MIME-Version: 1.0 To: dev@httpd.apache.org Subject: Re: svn commit: r682389 - in /httpd/httpd/trunk: CHANGES modules/generators/mod_cgid.c References: <20080804134908.1AF6F2388988@eris.apache.org> In-Reply-To: <20080804134908.1AF6F2388988@eris.apache.org> X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Checked: Checked by ClamAV on apache.org On 08/04/2008 03:49 PM, covener@apache.org wrote: > Author: covener > Date: Mon Aug 4 06:49:07 2008 > New Revision: 682389 > > URL: http://svn.apache.org/viewvc?rev=682389&view=rev > Log: > *) mod_cgid: Pass along empty command line arguments from an ISINDEX > query that has consecutive '+' characters in the QUERY_STRING, > matching the behavior of mod_cgi. > > > Modified: > httpd/httpd/trunk/CHANGES > httpd/httpd/trunk/modules/generators/mod_cgid.c > Modified: httpd/httpd/trunk/modules/generators/mod_cgid.c > URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/generators/mod_cgid.c?rev=682389&r1=682388&r2=682389&view=diff > ============================================================================== > --- httpd/httpd/trunk/modules/generators/mod_cgid.c (original) > +++ httpd/httpd/trunk/modules/generators/mod_cgid.c Mon Aug 4 06:49:07 2008 > @@ -237,6 +237,9 @@ > ap_unescape_url(w); > av[idx++] = ap_escape_shell_cmd(p, w); > } > + else { > + av[idx++] = w; > + } > } > av[idx] = NULL; > return av; Thanks for keeping track of this. Wouldn't it make sense to keep the code identical in mod_cgi and mod_cgid? Regards Rüdiger