httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeff Trawick" <traw...@gmail.com>
Subject Re: svn commit: r683626 - in /httpd/httpd/trunk: CHANGES modules/dav/fs/repos.c
Date Fri, 08 Aug 2008 13:42:01 GMT
On Fri, Aug 8, 2008 at 5:28 AM, Joe Orton <jorton@redhat.com> wrote:

> On Thu, Aug 07, 2008 at 03:12:00PM -0000, Jeff Trawick wrote:
> > --- httpd/httpd/trunk/modules/dav/fs/repos.c (original)
> > +++ httpd/httpd/trunk/modules/dav/fs/repos.c Thu Aug  7 08:12:00 2008
> > @@ -1475,10 +1475,8 @@
> >          /* append this file onto the path buffer (copy null term) */
> >          dav_buffer_place_mem(pool, &fsctx->path1, dirent.name, len + 1,
> 0);
> >
> > -
> > -        /* ### Optimize me, dirent can give us what we need! */
> >          status = apr_stat(&fsctx->info1.finfo, fsctx->path1.buf,
> > -                          APR_FINFO_NORM | APR_FINFO_LINK, pool);
> > +                          APR_FINFO_TYPE | APR_FINFO_LINK, pool);
> >          if (status != APR_SUCCESS && status != APR_INCOMPLETE) {
> >              /* woah! where'd it go? */
> >              /* ### should have a better error here */
> >
>
> Nit pick: on Unix APR_FINFO_PROT is needed too, to support the
> executable property...


plz show me where; I'm blind; thanks!

Mime
View raw message